Skip to content

Fix access_token description in revokeChannelToken - #130

Merged
mokuzon merged 1 commit into
mainfrom
users/mokuson/NO-ISSUE/fix-revoke-access-token-description
Jul 28, 2026
Merged

Fix access_token description in revokeChannelToken#130
mokuzon merged 1 commit into
mainfrom
users/mokuson/NO-ISSUE/fix-revoke-access-token-description

Conversation

@mokuzon

@mokuzon mokuzon commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

There was an openapi-generator bug (OpenAPITools/openapi-generator#24004, fixed in v7.24.0 via OpenAPITools/openapi-generator#24192).

It generated revokeChannelToken's access_token doc as A short-lived or long-lived channel access token. instead of this spec's Channel access token, and the SDKs merged it.

With v7.24.0, regeneration now tries to revert it:

Since the current SDK wording is correct for this endpoint (POST /v2/oauth/revoke only accepts short-lived or long-lived tokens), this PR updates the spec to match it instead.

The regeneration diff disappears and the PRs above stay closed.

@mokuzon
mokuzon marked this pull request as draft July 28, 2026 00:15
@github-actions

Copy link
Copy Markdown

JAVA

You can check generated code in java

Check the diff here

@github-actions

Copy link
Copy Markdown

PHP

You can check generated code in php

Check the diff here

@github-actions

Copy link
Copy Markdown

PYTHON

You can check generated code in python

Check the diff here

@github-actions

Copy link
Copy Markdown

NODEJS

You can check generated code in nodejs

Check the diff here

@github-actions

Copy link
Copy Markdown

RUBY

You can check generated code in ruby

Check the diff here

@github-actions

Copy link
Copy Markdown

GO

You can check generated code in go

Check the diff here

@mokuzon mokuzon self-assigned this Jul 28, 2026
@mokuzon
mokuzon marked this pull request as ready for review July 28, 2026 00:30
@mokuzon
mokuzon requested a review from a team July 28, 2026 00:30
@mokuzon
mokuzon added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit de8bd9e Jul 28, 2026
24 checks passed
@mokuzon
mokuzon deleted the users/mokuson/NO-ISSUE/fix-revoke-access-token-description branch July 28, 2026 00:52
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi,
so pull requests fail while the pinned submodule is behind. Pull in
line/line-openapi@de8bd9e (Fix access_token description in
revokeChannelToken, line/line-openapi#130), which replaces the closed
auto-generated update PR #879. The resulting diff is doc comments only.
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi
(git submodule update --remote), so this PR fails that check while the
pinned submodule is behind. Pull in line/line-openapi@de8bd9e (Fix
access_token description in revokeChannelToken, line/line-openapi#130),
which replaces the closed auto-generated update PR #879. The resulting
diff is doc comments only.
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi
(git submodule update --remote), so this PR fails that check while the
pinned submodule is behind. Pull in line/line-openapi@de8bd9e (Fix
access_token description in revokeChannelToken, line/line-openapi#130),
which replaces the closed auto-generated update PR #879. The resulting
diff is doc comments only.
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi
(git submodule update --remote), so this PR fails that check while the
pinned submodule is behind. Pull in line/line-openapi@de8bd9e (Fix
access_token description in revokeChannelToken, line/line-openapi#130),
which replaces the closed auto-generated update PR #879. The resulting
diff is doc comments only.
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi
(git submodule update --remote), so this PR fails that check while the
pinned submodule is behind. Pull in line/line-openapi@de8bd9e (Fix
access_token description in revokeChannelToken, line/line-openapi#130),
which replaces the closed auto-generated update PR #879. The resulting
diff is doc comments only.
mokuzon added a commit to line/line-bot-sdk-php that referenced this pull request Jul 28, 2026
The generate-code workflow regenerates against the latest line-openapi
(git submodule update --remote), so this PR fails that check while the
pinned submodule is behind. Pull in line/line-openapi@de8bd9e (Fix
access_token description in revokeChannelToken, line/line-openapi#130),
which replaces the closed auto-generated update PR #879. The resulting
diff is doc comments only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants